From 018cf24c80090f1ef091ce1ac0d4a0a1dab3bec3 Mon Sep 17 00:00:00 2001 From: Neal Frager Date: Fri, 3 Oct 2025 10:25:14 +0100 Subject: [PATCH] board/versal/post-image: remove unnecessary mkdir The board/versal/post-image.sh script has an unnecessary mkdir command: mkdir -p "${BINARIES_DIR}" This directory is created before calling the post image scripts, in [1]. Just above the command, the script is making a symlink for the Linux DTB in the ${BINARIES_DIR}, so if the ${BINARIES_DIR} did not already exist with images inside, the script would fail regardless of whether this mkdir is executed or not. For this reason, remove the mkdir call from the script because it is not necessary. [1] https://gitlab.com/buildroot.org/buildroot/-/blob/2025.08/Makefile#L829 Signed-off-by: Neal Frager [Julien: add a link showing where the directory is created] Signed-off-by: Julien Olivain --- board/versal/post-image.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/board/versal/post-image.sh b/board/versal/post-image.sh index b5ce2e3f0c..3242e4384a 100755 --- a/board/versal/post-image.sh +++ b/board/versal/post-image.sh @@ -12,7 +12,6 @@ FIRST_DT=$(sed -nr \ BOARD_DIR="$(dirname "$0")" -mkdir -p "${BINARIES_DIR}" cat <<-__HEADER_EOF > "${BINARIES_DIR}/bootgen.bif" the_ROM_image: {