From 12a5bd91eb11b7fcf82c9eac73655806696f9323 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Sat, 3 Jan 2026 23:43:21 +0100 Subject: [PATCH] package/libgtk4: add missing dependency for BR2_PACKAGE_LIBGTK4_GSTREAMER Back when the libgtk4 package was introduced in commit faf2a1d2abfbff79fc0603def835066587144420, its BR2_PACKAGE_LIBGTK4_GSTREAMER option did not properly propagate the dependencies of BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL, causing the following Config.in warning: WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE [=y] && (BR2_PACKAGE_HAS_LIBGL [=n] || BR2_PACKAGE_HAS_LIBGLES [=n]) Selected by [y]: - BR2_PACKAGE_LIBGTK4_GSTREAMER [=y] && BR2_PACKAGE_LIBGTK4 [=y] Fix that by properly propagating the dependency. Fixes: faf2a1d2abfbff79fc0603def835066587144420 ("package/libgtk4: new package") Signed-off-by: Thomas Petazzoni Signed-off-by: Julien Olivain (cherry picked from commit d0034ff96531b8993ed591323e37d0c1dec4de48) Signed-off-by: Thomas Perale --- package/libgtk4/Config.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/libgtk4/Config.in b/package/libgtk4/Config.in index 99553fc44e..8c01ffd535 100644 --- a/package/libgtk4/Config.in +++ b/package/libgtk4/Config.in @@ -84,6 +84,7 @@ config BR2_PACKAGE_LIBGTK4_X11 config BR2_PACKAGE_LIBGTK4_GSTREAMER bool "gstreamer support" + depends on BR2_PACKAGE_HAS_LIBGL || BR2_PACKAGE_HAS_LIBGLES select BR2_PACKAGE_GSTREAMER1 select BR2_PACKAGE_GST1_PLUGINS_BASE select BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL @@ -91,6 +92,9 @@ config BR2_PACKAGE_LIBGTK4_GSTREAMER help Enable gstreamer support. +comment "gstreamer support needs an OpenGL or OpenGL ES backend" + depends on !BR2_PACKAGE_HAS_LIBGL && !BR2_PACKAGE_HAS_LIBGLES + config BR2_PACKAGE_LIBGTK4_DEMO bool "Install libgtk4 demo/example programs" select BR2_PACKAGE_SHARED_MIME_INFO