From 15764ad78e6495a0c1d940b83aab26c7bcde475f Mon Sep 17 00:00:00 2001 From: Julien Olivain Date: Fri, 22 Nov 2024 22:38:09 +0100 Subject: [PATCH] package/spice: re-enable on all cpu architectures Buildroot commit [1] restricted spice compilation to x86 only. As the log of this commit mention, this was because at that time, spice 0.12.0 was generating an error on untested cpu architectures. See [2] (we can also see that armv6+ platforms was apparently supported). Spice commit [3] (first included in spice v0.12.6) relaxed this error to a warning. The reason was that big endian support was improved, and also there was an intent to make testing easier. [1] https://gitlab.com/buildroot.org/buildroot/-/commit/4f452a86b8523d90ffa7a94cb1d540e574ceb165 [2] https://gitlab.freedesktop.org/spice/spice/-/blob/v0.12.0/configure.ac#L60 [3] https://gitlab.freedesktop.org/spice/spice/-/commit/f80eef8f9ca04f923752efbda043ab856801be8a Signed-off-by: Julien Olivain Reviewed-by: Vincent Jardin [Thomas: reduced commit to just re-enabling on all CPU architectures, created separate commits for the BR2_USE_MMU and gcc >= 6 fixes] Signed-off-by: Thomas Petazzoni --- package/spice/Config.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/package/spice/Config.in b/package/spice/Config.in index 1dc5ae3040..d3ca8b7c2c 100644 --- a/package/spice/Config.in +++ b/package/spice/Config.in @@ -1,12 +1,10 @@ comment "spice server needs a toolchain w/ wchar, threads, C++, gcc >= 6" - depends on BR2_i386 || BR2_x86_64 depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \ !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_6 config BR2_PACKAGE_SPICE bool "spice server" - depends on BR2_i386 || BR2_x86_64 depends on BR2_USE_MMU # libglib2 depends on BR2_USE_WCHAR # libglib2 depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2