From 32b4912a75d19b8883ddd8ed0c5851b4fe14e96b Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Fri, 7 Jun 2024 19:05:45 +0200 Subject: [PATCH] utils/checkpackagelib: instruct shellcheck to follow included files We do have a few shell scripts that have source directives (either with 'source' or with '.'), and they all are currently either globally ignored in .checkpackageignore, or have shellcheck directives to ignore the source statement (SC1090). So, we can safely instruct shellcheck where to lookup for sourced files; that does not trigger any new error. This will alow fixing some shellcheck errors in later commits. Signed-off-by: Yann E. MORIN Cc: Ricardo Martincoski [Arnout: use long option] Signed-off-by: Arnout Vandecappelle --- utils/checkpackagelib/tool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/checkpackagelib/tool.py b/utils/checkpackagelib/tool.py index 907ada704f..dcca65f62a 100644 --- a/utils/checkpackagelib/tool.py +++ b/utils/checkpackagelib/tool.py @@ -31,7 +31,7 @@ class Flake8(_Tool): class Shellcheck(_Tool): def run(self): - cmd = ['shellcheck', self.filename] + cmd = ['shellcheck', "--external-sources", self.filename] try: p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE) stdout = p.communicate()[0]