From f9867a725c12975af52dda9dffbdc33c3b0312db Mon Sep 17 00:00:00 2001 From: Ben Wolsieffer Date: Tue, 7 Feb 2023 17:53:37 +0100 Subject: [PATCH] package/uclibc: enable DODEBUG when BR2_ENABLE_RUNTIME_DEBUG The DODEBUG=y option of uClibc causes uClibc to be built with -O0 and -DDEBUG, which has a significant runtime performance impact. Currently, DODEBUG=y is passed when BR2_ENABLE_DEBUG=y, but BR2_ENABLE_DEBUG is only about enabling debugging symbols, not about runtime debugging additions. The more recently added BR2_ENABLE_RUNTIME_DEBUG option is precisely designed for that, so we changed the logic to pass DODEBUG=y when BR2_ENABLE_RUNTIME_DEBUG=y, and not BR2_ENABLE_DEBUG=y. This allows to build uClibc with debugging symbols when BR2_ENABLE_DEBUG=y, without disabling optimizations and adding more debugging features that have a runtime performance impact. Signed-off-by: Ben Wolsieffer [Thomas: extracted from https://patchwork.ozlabs.org/project/buildroot/patch/20220803200629.3172370-1-Ben.Wolsieffer@hefring.com/ and split into its own independent patch.] Signed-off-by: Thomas Petazzoni --- package/uclibc/uclibc.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk index 342d841087..4c05d36ab3 100644 --- a/package/uclibc/uclibc.mk +++ b/package/uclibc/uclibc.mk @@ -217,7 +217,7 @@ endif # # Debug # -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) define UCLIBC_DEBUG_CONFIG $(call KCONFIG_ENABLE_OPT,DODEBUG) endef