mirror/buildroot
1
0
Fork 0
mirror of https://gitlab.com/buildroot.org/buildroot.git synced 2026-08-01 21:23:51 -09:00
Code Issues Packages Projects Releases Wiki Activity

utils/check-symbols: allow BR2_BROKEN to be unused

Browse Source 
Commit [1] introduced the BR2_BROKEN hidden symbol. The intent of
this symbol is to temporarily mark a configuration known to be broken.
This commit was added to fix an undefined usage of the symbol, in a
previous commit [2].

With this somewhat special symbol, it is also perfectly normal to
have no use of it.

Running the command "utils/check-symbols" in a state there is no usage
of the BR2_BROKEN, the script fails with output:

    Config.in:15: BR2_BROKEN defined but not referenced

This commit adds an exception for this symbol, allowing it to be
unused in the whole Buildroot tree.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/8925433382

[1] 2ddc5808cd
[2] 11a8cdd2bb

Signed-off-by: Julien Olivain <ju.o@free.fr>
Signed-off-by: Romain Naour <romain.naour@smile.fr>
This commit is contained in:
Julien Olivain
2025-01-23 22:35:41 +01:00
committed by Romain Naour
parent ea3f2d9f93
commit fa98239074
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
utils/checksymbolslib/br.py
View File

@@ -45,6 +45,10 @@ symbols_not_defined_for_fake_virtual_packages = [
'BR2_PACKAGE_PROVIDES_TOOLCHAIN_BUILDROOT', 'BR2_PACKAGE_PROVIDES_TOOLCHAIN_BUILDROOT',
'BR2_PACKAGE_PROVIDES_TOOLCHAIN_BARE_METAL_BUILDROOT', 'BR2_PACKAGE_PROVIDES_TOOLCHAIN_BARE_METAL_BUILDROOT',
] ]
# Config.in
symbols_possibly_unused = [
'BR2_BROKEN',
]
# fs/common.mk # fs/common.mk
suffixes_not_defined_for_all_rootfs_types = [ suffixes_not_defined_for_all_rootfs_types = [
'_BZIP2', '_BZIP2',

2
utils/checksymbolslib/db.py
View File

@@ -155,6 +155,8 @@ class DB:
continue continue
if legacy_usage in entries: if legacy_usage in entries:
continue continue
if symbol in br.symbols_possibly_unused:
continue
if symbol in br.symbols_used_only_in_source_code: if symbol in br.symbols_used_only_in_source_code:
continue continue
if symbol in br.symbols_used_only_for_host_variant: if symbol in br.symbols_used_only_for_host_variant: