mirror of
https://gitlab.com/buildroot.org/buildroot.git
synced 2026-08-01 13:18:36 -09:00
ded3e0045a
This patch brings the entire stack of Debian patches on grub2 titled "cve-2025-jan" and available at: https://salsa.debian.org/grub-team/grub/-/tree/debian/2.12-9/debian/patches/cve-2025-jan?ref_type=tags As of this exact Debian grub2 version 2.12-9. Some minor conflicts had to be fixed. All patches are in upstream Grub master, but mixed with hundreds of other changes, which is why Debian's effort to backport them has been leveraged here. In addition to those patches, 2 extra patches are added: 0073-net-drivers-ieee1275-ofnet-Add-missing-grub_malloc.patch 0074-Constant-time-grub_crypto_memcmp.patch The first one fixes an issue in one of the earlier patches. The fix is not in Debian, but is in upstream Grub. The second one fixes another CVE, not fixed in Debian, but fixed in OpenSUSE. This fix is not upstream as upstream has decided to move to libgcrypt instead to avoid the problem, but that's a fairly large change. Overall, this patch fixes all CVEs currently reported by pkg-stats against our grub2 package, namely: CVE-2024-45777 CVE-2024-45778 CVE-2024-45779 CVE-2024-45780 CVE-2024-45782 CVE-2024-56737 CVE-2024-56738 CVE-2025-0678 CVE-2025-0684 CVE-2025-0685 CVE-2025-0686 CVE-2025-0689 CVE-2025-1125 With the previous fixes on runtime tests added (to use glibc toolchains to build grub2 tests), this commit successfully passes all tests: - The ISO9660 tests that use grub2: https://gitlab.com/tpetazzoni/buildroot/-/pipelines/1985234563 - The grub2 tests: https://gitlab.com/tpetazzoni/buildroot/-/pipelines/1985234685 Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> [Julien: also tested by building and booting - qemu_aarch64_sbsa_defconfig - qemu_arm_ebbr_defconfig - qemu_loongarch64_virt_efi_defconfig - qemu_riscv64_virt_efi_defconfig - pc_x86_64_bios_defconfig - pc_x86_64_efi_defconfig ] Tested-by: Julien Olivain <ju.o@free.fr> [Julien: - fix patch #72 upstream link to point to the initial patch sumbission rather than a reply - merge two _IGNORE_CVES blocks for patch #50 into a single one - order _IGNORE_CVES blocks by numerical patch order - order numerically the CVE list in commit log - add a "Fixes:" tag in patch #74 since its commit log does not mention the CVE. ] Signed-off-by: Julien Olivain <ju.o@free.fr>
75 lines
2.2 KiB
Diff
75 lines
2.2 KiB
Diff
From 762eda67c7b0e83011040d5dbcc2ddc9a03b90cd Mon Sep 17 00:00:00 2001
|
|
From: Jonathan Bar Or <jonathanbaror@gmail.com>
|
|
Date: Thu, 23 Jan 2025 19:17:05 +0100
|
|
Subject: [PATCH] commands/read: Fix an integer overflow when supplying more
|
|
than 2^31 characters
|
|
|
|
The grub_getline() function currently has a signed integer variable "i"
|
|
that can be overflown when user supplies more than 2^31 characters.
|
|
It results in a memory corruption of the allocated line buffer as well
|
|
as supplying large negative values to grub_realloc().
|
|
|
|
Fixes: CVE-2025-0690
|
|
|
|
Reported-by: Jonathan Bar Or <jonathanbaror@gmail.com>
|
|
Signed-off-by: Jonathan Bar Or <jonathanbaror@gmail.com>
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
Upstream: dad8f502974ed9ad0a70ae6820d17b4b142558fc
|
|
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
|
|
---
|
|
grub-core/commands/read.c | 19 +++++++++++++++----
|
|
1 file changed, 15 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/grub-core/commands/read.c b/grub-core/commands/read.c
|
|
index 597c90706..8d72e45c9 100644
|
|
--- a/grub-core/commands/read.c
|
|
+++ b/grub-core/commands/read.c
|
|
@@ -25,6 +25,7 @@
|
|
#include <grub/types.h>
|
|
#include <grub/extcmd.h>
|
|
#include <grub/i18n.h>
|
|
+#include <grub/safemath.h>
|
|
|
|
GRUB_MOD_LICENSE ("GPLv3+");
|
|
|
|
@@ -37,13 +38,14 @@ static const struct grub_arg_option options[] =
|
|
static char *
|
|
grub_getline (int silent)
|
|
{
|
|
- int i;
|
|
+ grub_size_t i;
|
|
char *line;
|
|
char *tmp;
|
|
int c;
|
|
+ grub_size_t alloc_size;
|
|
|
|
i = 0;
|
|
- line = grub_malloc (1 + i + sizeof('\0'));
|
|
+ line = grub_malloc (1 + sizeof('\0'));
|
|
if (! line)
|
|
return NULL;
|
|
|
|
@@ -59,8 +61,17 @@ grub_getline (int silent)
|
|
line[i] = (char) c;
|
|
if (!silent)
|
|
grub_printf ("%c", c);
|
|
- i++;
|
|
- tmp = grub_realloc (line, 1 + i + sizeof('\0'));
|
|
+ if (grub_add (i, 1, &i))
|
|
+ {
|
|
+ grub_error (GRUB_ERR_OUT_OF_RANGE, N_("overflow is detected"));
|
|
+ return NULL;
|
|
+ }
|
|
+ if (grub_add (i, 1 + sizeof('\0'), &alloc_size))
|
|
+ {
|
|
+ grub_error (GRUB_ERR_OUT_OF_RANGE, N_("overflow is detected"));
|
|
+ return NULL;
|
|
+ }
|
|
+ tmp = grub_realloc (line, alloc_size);
|
|
if (! tmp)
|
|
{
|
|
grub_free (line);
|
|
--
|
|
2.50.1
|
|
|