mirror of
https://gitlab.com/buildroot.org/buildroot.git
synced 2026-08-01 21:23:51 -09:00
support/download/{curl, cvs, git, svn}: disable new shellcheck 0.9.0 errors
As for SC1090 and SC2016 [1], disable SC1091 and SC2294 too since they
are now reported by shellcheck 0.9.0:
In support/download/curl line 42:
eval ${CURL} "${@}"
^--^ SC2294 (warning): eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
[1] bcee3ca6d6
Signed-off-by: Romain Naour <romain.naour@smile.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
committed by
Peter Korsgaard
parent
402b1afcdf
commit
13deac1e39
@@ -39,6 +39,7 @@ _curl() {
|
||||
# Note: please keep command below aligned with what is printed above
|
||||
_plain_curl() {
|
||||
# shellcheck disable=SC2086 # We want splitting
|
||||
# shellcheck disable=SC2294
|
||||
eval ${CURL} "${@}"
|
||||
}
|
||||
|
||||
|
||||
@@ -47,6 +47,7 @@ _cvs() {
|
||||
# Note: please keep command below aligned with what is printed above
|
||||
_plain_cvs() {
|
||||
# shellcheck disable=SC2086 # We really want word splitting in CVS
|
||||
# shellcheck disable=SC2294
|
||||
eval timeout 10m ${CVS} "${@}"
|
||||
}
|
||||
|
||||
|
||||
@@ -22,6 +22,7 @@ set -e
|
||||
# GIT : the git command to call
|
||||
|
||||
# shellcheck disable=SC1090 # Only provides mk_tar_gz()
|
||||
# shellcheck disable=SC1091
|
||||
. "${0%/*}/helpers"
|
||||
|
||||
# Save our path and options in case we need to call ourselves again
|
||||
@@ -91,6 +92,7 @@ _git() {
|
||||
# Note: please keep command below aligned with what is printed above
|
||||
_plain_git() {
|
||||
# shellcheck disable=SC2086 # We want word-splitting for GIT
|
||||
# shellcheck disable=SC2294
|
||||
eval GIT_DIR="${git_cache}/.git" ${GIT} "${@}"
|
||||
}
|
||||
|
||||
|
||||
@@ -22,6 +22,7 @@ set -e
|
||||
# SVN : the svn command to call
|
||||
|
||||
# shellcheck disable=SC1090 # Only provides mk_tar_gz()
|
||||
# shellcheck disable=SC1091
|
||||
. "${0%/*}/helpers"
|
||||
|
||||
quiet=
|
||||
@@ -52,6 +53,7 @@ _svn() {
|
||||
# Note: please keep command below aligned with what is printed above
|
||||
_plain_svn() {
|
||||
# shellcheck disable=SC2086 # We want word-splitting for SVN
|
||||
# shellcheck disable=SC2294
|
||||
eval ${SVN} "${@}"
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user