mirror/buildroot
1
0
Fork 0
mirror of https://gitlab.com/buildroot.org/buildroot.git synced 2026-08-08 00:20:38 -09:00
Code Issues Packages Projects Releases Wiki Activity

support/dependencies/check-host-cmake.sh: verify version argument

Browse Source 
When running 'make show-info-all' without a '.config', it is possible to
trigger this script without passing a version number.

The 'show-info-all' target is special because it forces the reading of
all packages without requiring a .config, so BR2_HOST_CMAKE_AT_LEAST is
unset and the script is called as:
  check-host-cmake.sh cmake cmake3

Without validation, the integer comparisons below would produce errors
like:
  check-host-cmake.sh: line 37: [: cmake: integer expected

It's possible to trigger this by adding the following file somewhere in
you path:

cat >/bin/cmake3 <<EOF
echo "cmake version 4.3.3 CMake suite maintained and supported by Kitware (kitware.com/cmake)."
EOF
make show-info-all

The same issue can also occur with pkg-stats.

Signed-off-by: Thomas Perale <thomas.perale@mind.be>
Signed-off-by: Arnout Vandecappelle <arnout@rnout.be>
(cherry picked from commit e7533662a4)
Signed-off-by: Thomas Perale <thomas.perale@mind.be>
This commit is contained in:
Thomas Perale
2026-05-29 19:51:56 +02:00
parent ba410d9a15
commit 2a9e6de11c
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
support/dependencies/check-host-cmake.sh
View File

@@ -6,6 +6,18 @@
major_min="${1%.*}"
minor_min="${1#*.}"
# When running 'make show-info-all' or pkg-stats, it is possible to trigger this
# script without passing a version number. These cases are special because they
# force the reading of all packages without requiring a .config, so
# BR2_HOST_CMAKE_AT_LEAST is unset and the script is called as:
# check-host-cmake.sh cmake cmake3
# Without validation, the integer comparisons below would produce errors like:
# check-host-cmake.sh: line 37: [: cmake: integer expected
# The following lines checks we have a single digit number from $1 before
# continuing the script.
[ "${major_min}" -eq "${major_min}" ] 2>/dev/null || exit 1
[ "${minor_min}" -eq "${minor_min}" ] 2>/dev/null || exit 1
shift
for candidate; do